Make aborted and disabled icon colours themable #10032

Jonny-vb · 2024-12-06T13:29:02Z

Update the aborted and disabled icon colours to be set from variables instead of hard coded colours, allowing them to be overwritten by themes.

See:
jenkinsci/dark-theme-plugin#550
jenkinsci/dark-theme-plugin#552

Testing done

No tests written as is a pure UI update

Proposed changelog entries

Make pipeline icons for aborted and disabled themeable

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@timja

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

welcome · 2024-12-06T13:29:06Z

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

janfaracik

LGTM - need to confirm this is needed though jenkinsci/dark-theme-plugin#550 (comment)

timja

I would like to understand this before we proceed:
jenkinsci/dark-theme-plugin#550 (comment)

but once thats understood this is good

timja · 2024-12-07T18:58:04Z

@janfaracik has figured it out in jenkinsci/dark-theme-plugin#550 (comment)

This needs fixing in branch-api-plugin

timja · 2024-12-10T11:03:58Z

Alternatively adapting ballColorTd may be enough:
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/hudson/ballColorTd.jelly

Make aborted and disabled icon colours themable

53c7c58

janfaracik added the web-ui The PR includes WebUI changes which may need special expertise label Dec 6, 2024

janfaracik approved these changes Dec 6, 2024

View reviewed changes

janfaracik added the skip-changelog Should not be shown in the changelog label Dec 6, 2024

Merge branch 'master' into feature/make-more-icons-themeable

dd7ed0c

krisstern approved these changes Dec 7, 2024

View reviewed changes

timja requested changes Dec 7, 2024

View reviewed changes

Add missing semicolon

e161587

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make aborted and disabled icon colours themable #10032

Make aborted and disabled icon colours themable #10032

Jonny-vb commented Dec 6, 2024

Submitter checklist

Maintainer checklist

welcome bot commented Dec 6, 2024

janfaracik left a comment •

edited

Loading

timja left a comment

timja commented Dec 7, 2024

timja commented Dec 10, 2024

Make aborted and disabled icon colours themable #10032

Are you sure you want to change the base?

Make aborted and disabled icon colours themable #10032

Conversation

Jonny-vb commented Dec 6, 2024

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

welcome bot commented Dec 6, 2024

janfaracik left a comment • edited Loading

Choose a reason for hiding this comment

timja left a comment

Choose a reason for hiding this comment

timja commented Dec 7, 2024

timja commented Dec 10, 2024

janfaracik left a comment •

edited

Loading